.github/workflows/build: enable pushing to dockerhub#17
Open
classabbyamp wants to merge 1 commit intovoid-linux:masterfrom
Open
.github/workflows/build: enable pushing to dockerhub#17classabbyamp wants to merge 1 commit intovoid-linux:masterfrom
classabbyamp wants to merge 1 commit intovoid-linux:masterfrom
Conversation
Member
Author
|
we should also consider removing the old ghcr images so people migrate to the updated ones: |
Member
|
Perhaps explicitly mention |
classabbyamp
force-pushed
the
dockerhub
branch
from
ad5434c to
40ce3d4
Compare
|
Is there a discussion I missed which speaks against merging this? |
Member
Author
|
not really |
|
Still not sure why this is not being merged. Is this just a "lets wait if something comes up against it" or do we actually need someone else to approve it? |
Member
Author
|
probably because we've been doing other things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
despite dockerhub's checkered recent past, I think this is beneficial, especially as alpha.de's DNS no longer works, breaking people who use the current dockerhub container as-is. If we do this, we should be able to remove the old images and direct people to the new ones.
This will require dockerhub credentials be added as secrets.